Solution #5122
Open
Solution #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-ignatow
approved these changes
Jan 27, 2025
Comment on lines
+7
to
+12
| const PRICE_OF_RENT = 40; | ||
| let totalCost = days * PRICE_OF_RENT; | ||
| const SHORT_TERM = 3; | ||
| const SMALL_DISCOUNT = 20; | ||
| const LONG_TERM = 7; | ||
| const BIG_DISCOUNT = 50; |
There was a problem hiding this comment.
Please declare consts outside functions if possible - with your solution you re-declare these variables on each function call
Comment on lines
+18
to
+26
| if (days < LONG_TERM) { | ||
| totalCost = totalCost - SMALL_DISCOUNT; | ||
|
|
||
| return totalCost; | ||
| } | ||
|
|
||
| totalCost = totalCost - BIG_DISCOUNT; | ||
|
|
||
| return totalCost; |
There was a problem hiding this comment.
No need to reassign totalCost
Just return what you need
Suggested change
| if (days < LONG_TERM) { | |
| totalCost = totalCost - SMALL_DISCOUNT; | |
| return totalCost; | |
| } | |
| totalCost = totalCost - BIG_DISCOUNT; | |
| return totalCost; | |
| if (days < LONG_TERM) { | |
| return totalCost - SMALL_DISCOUNT; | |
| } | |
| return totalCost - BIG_DISCOUNT; |
If you do this - you can change
let totalCost = days * PRICE_OF_RENT; to
const totalCost = days * PRICE_OF_RENT;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.